Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muse Dash: 6th Anniversary Song update #3593

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Muse Dash: 6th Anniversary Song update #3593

merged 2 commits into from
Jun 29, 2024

Conversation

DeamonHunter
Copy link
Collaborator

What is this fixing or adding?

Adds 6th anniversary songs.

Note: Territory Battles has not been updated yet. So will keep the same info as the last PR.

How was this tested?

With tests.

@DeamonHunter DeamonHunter added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jun 27, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 27, 2024
ScipioWright
ScipioWright approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just gonna reasonably assume the world maintainer knows what they're doing with a change like this

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 27, 2024
Exempt-Medic
Exempt-Medic approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, names and difficulty values match those in game

@NewSoupVi NewSoupVi merged commit 2424fb0 into ArchipelagoMW:main Jun 29, 2024
11 checks passed
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
@DeamonHunter @GameWyrm
Muse Dash: 6th Anniversary Song update (ArchipelagoMW#3593)
bb97afb 
* 6th Anniversary Update songs.

* Forgot to fix the name of Heartbeat.
@DeamonHunter DeamonHunter deleted the Deamon/6thAnniversayUpdate branch December 23, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeamonHunter @ScipioWright @NewSoupVi @Exempt-Medic